lua, PanelLayout - don't create a div if preamble is empty #11999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good immediate fix, thank you! We might consider adding the descaffolding filter to |
|
Thanks !
Yeah I was planning to leave this on the side. We shouldn't be needing this in theory if we don't create those empty divs. In LaTeX, I think we added this specific handling in finalizer because it could break the document making it not renderable. |
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11964
Default preamble is empty list and we need to make sure to not create a
Divwhen empty preamble is found.In typst or HTML this would create an empty block - for LaTeX we do have a finalizer to descaffold a Div with no attributes at all.